feat: add options to define background color using HEX or RBGA values along with the color picker#94
Open
IdrisGit wants to merge 1 commit into
Conversation
|
@IdrisGit is attempting to deploy a commit to the vercel oss program Team on Vercel. A member of the Team first needs to authorize it. |
Collaborator
|
Hi @IdrisGit thank you for your contribution, can you please give a high level idea of this PR and how did you implemented it... |
Author
|
Hi @AniketR10 sure, Will I was creating some screenshots for my website, I wanted to use a specific color for the background, however the current background color option only has a color picker with sliders, which is not convenient when you want to use a specific color you know thw values of 😅. So I have added two inputs, one for rgba values and one for hex codes, those values are then converted to hsv value, underlying color definition stays in hsv only. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
screenshot of how it would look
